UI: Fix Gantt queued tooltip end date#69197
Closed
YinkaMetrics wants to merge 1 commit into
Closed
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
YinkaMetrics
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
Member
There was a problem hiding this comment.
Thanks for opening the PR.
Closing in favor of #68570 which was just merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gantt queued and scheduled segments reused the hovered segment end as the tooltip end date. For queued segments, that made the tooltip show the queue end/start time as the task end date instead of the actual task end.
This keeps the effective task end date on every Gantt segment and uses it when building tooltip summaries, so queued/scheduled segment tooltips stay consistent with the execution segment.
closes: #68174
Validation:
pnpm vitest run src/layouts/Details/Gantt/utils.test.tspnpm prettier --check src/layouts/Details/Gantt/GanttTimeline.tsx src/layouts/Details/Gantt/utils.ts src/layouts/Details/Gantt/utils.test.tspnpm eslint --quiet src/layouts/Details/Gantt/GanttTimeline.tsx src/layouts/Details/Gantt/utils.ts src/layouts/Details/Gantt/utils.test.tspnpm tsc --p tsconfig.app.json --noEmitprekcommit hooksNote: I did not attach screenshots because this is a tooltip timestamp data fix with regression coverage and no layout/styling change.
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines